Remove the requirement at least one peer #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prd-fox
requested review from
chris-j-h,
melowe,
namtruong,
nicolae-leonte-go and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=========================================
Coverage 99.43% 99.43%
Complexity 1636 1636
=========================================
Files 254 254
Lines 4979 4979
Branches 245 245
=========================================
Hits 4951 4951
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
melowe
approved these changes
Dec 28, 2018
SatpalSandhu61
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All operations on peers either:
so having a list of no peers will perform no actions of the loop, or return before accessing the list with an unknown index.
Thus, having no peers at startup means that the node will sit idle until someone else connects to it. The list is still required to be present, but it an be empty.
Fixes #578
Fixes #577